search

tc39 / proposal-intl-displaynames-v2

Intl DisplayNames API V2
https://tc39.es/proposal-intl-displaynames-v2/
MIT License
23 stars 3 forks source link

Rename dialectHandling to languageDisplay #31

Closed FrankYFTang closed 3 years ago

FrankYFTang commented 3 years ago

In https://github.com/tc39/intl-displaynames-v2/issues/29 @sffc suggest we rename this dialectHandling to languageDisplay. I spin off that part of request to this issue.

ryzokuken commented 3 years ago

+1 for this rename. @anba what do you think?

FrankYFTang commented 3 years ago

Here is what @sffc proposed (I prefer to move here as a separated issue) in https://github.com/tc39/intl-displaynames-v2/issues/29#issuecomment-822777071

If we were to add it to this proposal, the API could be:

new Intl.DisplayNames("en", { type: "language", languageDisplay: "standard" })
new Intl.DisplayNames("en", { type: "language", languageDisplay: "dialect" })

This would be parallel to "currencyDisplay" and such in Intl.NumberFormat. The options are relevant only for certain types.

Notice I leave the "menu" issue out, I think that should be discussed and addressed separately in https://github.com/tc39/intl-displaynames-v2/issues/30

anba commented 3 years ago

+1 for this rename. @anba what do you think?

Sounds good to me.

sffc commented 3 years ago

Discussion: https://github.com/tc39/ecma402/blob/master/meetings/notes-2021-05-06.md#rename-dialecthandling-to-languagedisplay-31