tc39 / proposal-intl-duration-format

https://tc39.es/proposal-intl-duration-format
MIT License
165 stars 18 forks source link

PartitionDurationFormatPattern: Unnecessary check for [[MillisecondsStyle]] #152

Closed anba closed 1 year ago

anba commented 1 year ago

PartitionDurationFormatPattern, steps 4.l.9.b.i-iii.:

i. Let nextValue be duration.[[Seconds]]. ii. Let nextDisplay be durationFormat.[[SecondsDisplay]]. iii. If durationFormat.[[MillisecondsStyle]] is "numeric", then   i. Set nextValue to nextValue + duration.[[Milliseconds]] / 103 + duration.[[Microseconds]] / 106 + duration.[[Nanoseconds]] / 109.

Can be simplified to:

i. Let nextValue be duration.[[Seconds]] + duration.[[Milliseconds]] / 103 + duration.[[Microseconds]] / 106 + duration.[[Nanoseconds]] / 109. ii. Let nextDisplay be durationFormat.[[SecondsDisplay]].

Because durationFormat.[[MillisecondsStyle]] is "numeric" is always true in this branch.