Closed anba closed 8 months ago
This was previously mentioned in https://github.com/tc39/proposal-intl-duration-format/pull/150#issuecomment-1576233180.
There's recent consensus for treating undefined
fractionalDigits
as meaning "as many fractional digits as needed"
https://github.com/tc39/proposal-intl-duration-format/issues/144#issuecomment-1499823791
There's recent consensus for treating
undefined
fractionalDigits
as meaning "as many fractional digits as needed"
This isn't changed with this PR. Only the resolvedOptions
output is changed from fractionalDigits: undefined
to not emitting a fractionalDigits
property at all.
This PR contains way too many editorial changes. Could we split that?
This PR contains way too many editorial changes. Could we split that?
As mentioned above, this PR applies on top of #166. When #166 gets merged, this PR will consist of only a single commit.
TG2 discussion and approval on the normative change: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-09-07.md#normative-dont-output-fractionaldigits-when-the-value-is-undefined-167
@ben-allen @sffc @ryzokuken This is discussed and agreed in TG2 in 2023-09-07 but we need someone to bring this up to TG1 in Nov 2023 before this can be merged.
Rebased now that #166 is merged.
2023-11-28: This PR achieved TC39-TG1 consensus.
For consistency with other Intl objects, don't output "fractionalDigits" when its value is
undefined
.Applies on top #166.