tc39 / proposal-intl-duration-format

https://tc39.es/proposal-intl-duration-format
MIT License
171 stars 18 forks source link

Incorrect access of [[HoursValue]] and [[SecondsValue]] of durationFormat in PartitionDurationFormatPattern #190

Closed FrankYFTang closed 6 months ago

FrankYFTang commented 7 months ago

This bug is introduced in https://github.com/tc39/proposal-intl-duration-format/pull/180

There are no [[SecondsValue]] nor [[HoursValue]] defined in https://tc39.es/proposal-intl-duration-format/#sec-properties-of-intl-durationformat-instances

But in https://tc39.es/proposal-intl-duration-format/#sec-partitiondurationformatpattern 1.1.8 PartitionDurationFormatPattern ( durationFormat, duration )

step 9-j-i-2

2. Let hoursValue be durationFormat.[[HoursValue]].

and step 9-j-i-3-b

b. Let secondsValue be durationFormat.[[SecondsValue]].

this is not implementable.

FrankYFTang commented 7 months ago

@ben-allen @ryzokuken

FrankYFTang commented 7 months ago

@sffc

ben-allen commented 6 months ago

Marking as closed, since this issue is fixed by #188