search

tc39 / proposal-intl-duration-format

https://tc39.es/proposal-intl-duration-format
MIT License
163 stars 18 forks source link

Normative: turn useGrouping false for hours & smaller units when style is 2-digits or numeric #198

Closed FrankYFTang closed 3 weeks ago

FrankYFTang commented 4 months ago

Fix https://github.com/tc39/proposal-intl-duration-format/issues/192

sffc commented 4 months ago

TG2 approval: https://github.com/tc39/ecma402/blob/main/meetings/notes-2024-04-25.md#normative-turn-usegrouping-false-for-hours--smaller-units-when-style-is-2-digits-or-numeric-198

FrankYFTang commented 4 weeks ago

I have problem to update this PR to the latest spec text. The spec text got heavily changed by @ben-allen in editorial PR. @ben-allen could you look at your latest spec text and figure out how to address https://github.com/tc39/proposal-intl-duration-format/issues/192 ?

ben-allen commented 3 weeks ago

Updated to set useGrouping to *false* in FormatNumericHour, FormatNumericMinutes, FormatNumericSeconds. @FrankYFTang quick review?

FrankYFTang commented 2 weeks ago

This PR implemented what the TG2 agreed change and got merged. I think we need someone to bring this PR to the next TG1 to got official consensus for the change inside Stage 3.

ben-allen commented 2 weeks ago

@FrankYFTang My bad -- I thought we already had TG1 consensus on the previous version. Will add to agenda for next TG1.