Editorial: Match temporal AO names and parameters

tc39 / proposal-intl-duration-format

https://tc39.es/proposal-intl-duration-format

MIT License

163 stars 18 forks source link

Editorial: Match temporal AO names and parameters #200

Closed ben-allen closed 3 months ago

ben-allen commented 3 months ago

Editorial: Changed names and parameters of AOs to match the equivalents in Temporal:

* `IsValidDurationRecord` now `IsValidDuration`. Takes integers
  representing values of units instead of taking an ECMAScript language
  value.

* `DurationRecordSign` now `DurationRecord`, likewise takes integers
  rather than ECMAScript language value.

Addresses the concern in this comment on #173

Land after #173

sffc commented 3 months ago

Thanks for working on this!

FrankYFTang commented 3 months ago

We need to change https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/precision-exact-mathematical-values.js to match the up-to-date spec