search

tc39 / proposal-intl-numberformat-v3

Additional features for Intl.NumberFormat to solve key pain points.
MIT License
53 stars 12 forks source link

Editorial: Replace GetStringOrBooleanOption #125

Closed gibson042 closed 1 year ago

gibson042 commented 1 year ago

GetStringOrBooleanOption is performing operations that are highly specific to the NumberFormat "useGrouping" option, and should therefore not be named or written generically.

sffc commented 1 year ago

Not sure if I agree with this; I wrote it as a generic operation to emphasize that this isn't specific to NumberFormat; it's just another flavor of the GetOption AO.

gibson042 commented 1 year ago

You would have a point if it were intended for reuse, but that is not the case AFAIK. It's used for a single property, and even apologizes for that special casing with its "for historical reasons" note.

sffc commented 1 year ago

Superseded by https://github.com/tc39/proposal-intl-numberformat-v3/pull/132