search

tc39 / proposal-intl-relative-time

`Intl.RelativeTimeFormat` specification [draft]
http://tc39.github.io/proposal-intl-relative-time/
215 stars 24 forks source link

Question: why is minimumIntegerDigits set to 2? #80

Closed jungshik closed 6 years ago

jungshik commented 6 years ago

The current spec has the following provision: 

24. Perform ! CreateDataPropertyOrThrow(nfOptions, "minimumIntegerDigits", 2).

I wonder what the rationale is for that. Wouldn't it results in the zero-padding of a single digit number? 

03 days ago
In 07 hours
jungshik commented 6 years ago

See, for instance, https://chromium-review.googlesource.com/c/v8/v8/+/1124728/15/test/intl/relative-time-format/format-en.js

jungshik commented 6 years ago

Ping @zbraniecki :-)

zbraniecki commented 6 years ago

I'm 90% sure it was a mistake.

caridy commented 6 years ago

yeah, probably a copy and paste mistake from my side.

littledan commented 6 years ago

When I discussed this issue with @zbraniecki and @caridy , it sounded like the useGrouping: false setting was also unintentional. I'll make a PR to remove this.

Ms2ger commented 6 years ago

Tests: https://github.com/tc39/test262/pull/1655 and https://github.com/tc39/test262/pull/1662