search

tc39 / proposal-intl-relative-time

`Intl.RelativeTimeFormat` specification [draft]
http://tc39.github.io/proposal-intl-relative-time/
215 stars 24 forks source link

isFinite() does not seem to be formally defined #86

Closed Ms2ger closed 6 years ago

Ms2ger commented 6 years ago

1.1.3 PartitionRelativeTimePattern ( relativeTimeFormat, value, unit )

  1. If isFinite(value) is false, then throw a RangeError exception.

I can guess what it means, but it doesn't seem to be defined.

littledan commented 6 years ago

In ECMA-262, we usually check for the three nonfinite values, e.g., https://tc39.github.io/ecma262/#sec-isfinite-number . I'd suggest doing the same here. PRs welcome!