tc39 / proposal-logical-assignment

A proposal to combine Logical Operators and Assignment Expressions
https://tc39.es/proposal-logical-assignment/
MIT License
300 stars 13 forks source link

Stage 3 review #15

Closed bakkot closed 4 years ago

bakkot commented 4 years ago

Otherwise looks good to me.

jridgewell commented 4 years ago

Is there a reason that LogicalAssignmentPunctuator is its own production?

I couldn't get the pretty <ins> decoration to work with it as part of OtherPunctuator. So I made it a new production.

Is there a reason the algorithm for ??= is structured differently than the algorithms for &&= and ||=?

Updated.