Closed jridgewell closed 11 months ago
Why do we need a "ASCII punctuators that need escaping" phrase?
i suppose i could do it inline, but i'd still want a note to describe the list a bit, and the dfn seemed cleaner to me.
@jridgewell please rereview; i've addressed all your comments.
Everything in my original list looks good. But a new thing I've noticed, we're appending both Code Units and Strings to escapedList
:
- Append code unit U+005C (REVERSE SOLIDUS) to escapedList.
- …
- Append the elements of [UTF16EncodeCodePoint](https://tc39.es/ecma262/#sec-utf16encodecodepoint)(c) to escapedList.
@jridgewell thanks, fixed! lmk if there's more items, or if i can check you off :-)
LGTM
CharSet
construction? Eg, https://tc39.es/ecma262/#sec-compiletocharset'sCharacterClassEscape :: d
productioncuList
to something else. MaybeescapedList
?cuList
is empty" and use a defined "is empty" phrase and keep the same behavior.cuList
that need to become_cuList_
10.1.1 [[GetPrototypeOf]] ( )
0x00XY
references "unicode" references, shouldn't they all beU+00XY
?DecimalDigit
andWhiteSpace
should be|DecimalDigit|
and|WhiteSpace|
c
is a code point, can you compare it to aDecimalDigit
production?c
is a code point, can you compare it to aWhiteSpace
production?c
is a code point needs to be cast to a CharSetElement before we can check if it's an element of the set.