search

tc39 / proposal-regex-escaping

Proposal for investigating RegExp escaping for the ECMAScript standard
http://tc39.es/proposal-regex-escaping/
Creative Commons Zero v1.0 Universal
363 stars 32 forks source link

editorial: _escapedList_ mixes code units and code points #68

Closed michaelficarra closed 5 months ago

michaelficarra commented 5 months ago

It'd probably be best to create a string through repeated string-concatenations and call UTF16EncodeCodePoint directly.

ljharb commented 5 months ago

Good catch.

Your suggestion tho seems more complex than either converting the code units into code points while adding them, for example.

ljharb commented 5 months ago

I think that this is fixed by #67. Will reopen if not.