Closed bakkot closed 4 months ago
cc @erights @waldemarhorwat @gibson042 Please take a look.
How do I see a rendered form of this?
Thanks. FWIW LGTM, but I delegate an approval decision to @gibson042 who understands this better than I do.
Thanks for the rendering. Cut down the review effort for me by a huge factor.
Commits should be reviewed individually. Summary:
\$
etc where possibly; this is not possible for all punctuators, but it is for some\n
etc where possiblex
-mode RegExps, and someone writesnew RegExp(RegExp.escape('\uHEAD') + RegExp.escape('\uTAIL'), 'x')
where\uHEAD\uTAIL
encodes that non-BMP whitespace character, the resulting RegExp will match the character instead of being interpreted as whitespace and therefore (inx
-mode) ignorednew RegExp('\c' + RegExp.escape('Z'))
will either be an error (inu
- orv
-mode RegExps) or match the string'\\cZ'
(in other RegExps); this also has the effect that the result cannot combine with a preceding\x
or\u
when the first character isA-F
ora-f
. Fixes #66.