search

tc39 / proposal-regexp-match-indices

ECMAScript RegExp Match Indices
https://arai-a.github.io/ecma262-compare/?pr=1713
BSD 3-Clause "New" or "Revised" License
65 stars 13 forks source link

Add missing RegExp.prototype[@@replace] #18

Closed rbuckton closed 5 years ago

rbuckton commented 5 years ago

Adds spec text to describe the behavior of RegEexp.prototype[@@replace] with match options.

rbuckton commented 5 years ago

You can view a rendered version of the documentation changes here: https://tc39.es/proposal-regexp-match-offsets/pr/18/#sec-regexp.prototype-@@replace

rbuckton commented 5 years ago

This currently has the downside of calling CoerceMatchResult twice on Get(result, "0") (12.c.iii.2 and 15.d), though we were previously calling ToString twice as well.

rbuckton commented 5 years ago

I am going to merge this. If reviewers have any further input please feel free to file in the individual or meta review issues.

msaboff commented 5 years ago

I'm fine with these changes.