Missing grammar parametrization

tc39 / proposal-regexp-named-groups

Named capture groups for JavaScript RegExps

https://tc39.github.io/proposal-regexp-named-groups/

222 stars 21 forks source link

Missing grammar parametrization #19

Closed schuay closed 7 years ago

schuay commented 7 years ago

The way I understood grammar parametrization, the proposal seems to be missing parametrization in a couple of places that are (directly or indirectly) referenced with [?N]:

Pattern
Disjunction
Alternative
Term
CharacterClass
CharacterEscape
ClassEscape
ClassAtomNoDash
NonemptyClassRangesNoDash
NonemptyClassRanges
ClassRanges
ClassAtom

Sorry of the omission was intentional.

littledan commented 7 years ago

That's true. I left it out thinking that it wouldn't benefit anyone for clarity to see all this plumbing. For RegExps, the parameters are global, not contextual as in the main grammar. Do you think it's OK to handle this when integrating into the main spec in a PR? Is this making it harder to implement?

schuay commented 7 years ago

No, it's not an issue for me. Just wasn't sure how strictly the proposal should reflect the final state. I'll close this since you're aware of it.