tc39 / proposal-relative-indexing-method

A TC39 proposal to add an .at() method to all the basic indexable classes (Array, String, TypedArray)
MIT License
352 stars 19 forks source link

Web compatibility issue with Magic360 #28

Open evilpie opened 4 years ago

evilpie commented 4 years ago

We have had the item method on Arrays in Firefox Nightly for about two or three days and just found our first web compatibility issue with the Magic 360 library: https://www.magictoolbox.com/magic360/examples/

https://bugzilla.mozilla.org/show_bug.cgi?id=1668342

ljharb commented 4 years ago

Given that it's a paid library, is there any chance evangelism would be effective here?

syg commented 4 years ago

Aw man. Thanks for the debugging, @evilpie!

To summarize the Bugzilla bug, the issue seems to come down to the library treating the presence of .length and .item combined on an item to mean that it is an HTML collection.

We'll reach out to them as well.

ljharb commented 4 years ago

It's unfortunate the web doesn't typically offer any kind of brand checks to identify elements/collections :-/ seems like it'd avoid this class of problem.

evilpie commented 4 years ago

There is another issue with flickr.com: https://bugzilla.mozilla.org/show_bug.cgi?id=1669867. See #32

karlcow commented 4 years ago

Given that it's a paid library, is there any chance evangelism would be effective here?

Fixing the library is good. It is useful to understand how widespread it is and if it relies on a local install or not. Because fixing the library might not fix the websites.