search

tc39 / proposal-shadowrealm

ECMAScript Proposal, specs, and reference implementation for Realms
https://tc39.es/proposal-shadowrealm/
1.43k stars 67 forks source link

HostEnsureCanCompileStrings takes only one argument #367

Closed mgaudet closed 7 months ago

mgaudet commented 2 years ago

In the main spec HostEnsureCanCompileStrings takes only one argument; in the ShadowRealm use in PerformShadowRealmEval, it's passed two.

Unclear exactly the intent here; I suspect this should just be two calls?

caridy commented 2 years ago

Na' that's just it was recently changed in 262, we need to update the specs to catch up with https://github.com/tc39/ecma262/pull/2670

mgaudet commented 2 years ago

Perfect :)

caridy commented 8 months ago

@ptomato can we get the spec updated to reflect the latest from 262?

nicolo-ribaudo commented 8 months ago

Maybe let's wait a bit here, until when https://github.com/tc39/ecma262/pull/3222 is merged, since it touches the same AO.

caridy commented 8 months ago

https://github.com/tc39/ecma262/pull/3222 has consensus, and will be merged soon, right after that, we can fix this.