tc39 / proposal-signals

A proposal to add signals to JavaScript.
MIT License
2.87k stars 54 forks source link

"Effect" is undefined in `Computed.get` #202

Open prophile opened 2 weeks ago

prophile commented 2 weeks ago

The algorithm specification for "Method: Signal.Computed.prototype.get" says this in phase 1:

If the current execution context is notifying or if this Signal has the state ~computing~, or if this signal is an Effect and computing a computed Signal, throw an exception.

There's no other reference to an "Effect" so it's not clear what this means. There are some references to "effect Signal" elsewhere but this is also not defined anywhere.

EisenbergEffect commented 2 weeks ago

Good catch @prophile! I think this is some language left over from an earlier draft of the proposal. @littledan Should this just be updated to say Watcher or is there a more involved change here?

littledan commented 4 days ago

Yes, we should just be referring to Watcher here.