Open prophile opened 2 weeks ago
If I'm not mistaken adding watchers during notify already is an error, so it would follow that removing them should be as well.
This is definitely an area that needs further definition either way though, especially considering watcher.watch()
currently acts as a reset (something that needs to be defined further as well) and will never error in notify, but watcher.watch(signal)
will error.
In "Method: Signal.State.prototype.set(newValue)", we have:
A watcher's
notify
callback is permitted to call.watch
or.unwatch
(neither of their algorithms specify anotifying === false
check) and it's not clear what's supposed to happen in that case – if one watcher calls.unwatch
on another which would be notified by this algorithm but has not yet been so notified, should this stage of the algorithm still notify it or not?Consider the following code:
Should this print "notified B" and "notified A", or just "notified B"?
My reading of the current specification is that "previously
~watching~
Watcher" implies it should log both because they were both encountered in the search before running callbacks, but the polyfill in f7c550b just logs "notified B".