Stage 3 reviews

[lucacasonato]

Issue to track Stage 3 reviewers feedback

Spec: https://tc39.es/proposal-import-reflection/

Review PR: https://github.com/tc39/ecma262/pull/3094

Reviewers:

• [x] @nicolo-ribaudo
• [x] @littledan
• [x] @kriskowal

Editors:

• [x] @bakkot
• [x] @syg
• [x] @michaelficarra

[ljharb]

The notes only indicate two reviewers; was nicolo confirmed in plenary?

[nicolo-ribaudo]

I don't remember if I volunteered in plenary or after, but we can confirm it after the status update at the upcoming meeting if necessary.

[nicolo-ribaudo]

All my feedback about observable semantics and spec correctness has been addressed in https://github.com/tc39/proposal-import-reflection/pull/36 (+ my follow-up https://github.com/tc39/proposal-import-reflection/pull/37).

I opened https://github.com/tc39/proposal-import-reflection/pull/38 to discuss reverting the changes that this proposal does to the 262-HTML layering, but I don't think that that is a stage 3 blocker so consider my Stage 3 review done ✔️

[kriskowal]

My Stage 3 review is complete ✔️ I’m happy with the semantics.

[littledan]

LGTM, I'm happy with the semantics and specification text, though I'd prefer that #38 land (since it constrains hosts to be more regular).

[lucacasonato]

The proposal has now been raised as an ECMA262 PR for easier reviewing: https://github.com/tc39/ecma262/pull/3094

[syg]

Where is the HTML integration PR for the new host hook and the change to HostLoadImportedModule?

[guybedford]

@syg I'm in the process of rebasing the HTML PR to the latest spec changes. but the host hook doesn't actually integrate into the HTML PR - it's entirely defined in the Wasm ESM integration in https://webassembly.github.io/esm-integration/js-api/index.html#hostgetmodulesourcename.