search

tc39 / proposal-source-phase-imports

Proposal to enable importing modules at the source phase
https://tc39.es/proposal-source-phase-imports/
MIT License
132 stars 8 forks source link

spec feedback from @bakkot #52

Closed guybedford closed 7 months ago

guybedford commented 1 year ago

This incorporates the stage3 feedback from @bakkot, from https://github.com/tc39/ecma262/pull/3094, where their individual comments there are resolved per the changes here.

lucacasonato commented 1 year ago

Have integrated these changes into the upstream PR here:

I propose we stop updating this spec file, un-publish it and instead link to the PR. Maintaining both side by side will be painful. We're now at the stage of editor reviews, and doing that on the PR will be easier than on the repo.

ljharb commented 1 year ago

Every completed proposal still has its rendered spec text up; I think it's pretty important for future archival purposes.

lucacasonato commented 1 year ago

Sure we can leave it up (and add a link to the readme). But the proposal text won't be updated anymore. I don't think anyone backports PR changes to the separate specs

ljharb commented 1 year ago

Prior to stage 4, backporting PR changes is what's typically done.