Stage 3 Checklist - Githubissues

tc39 / proposal-string-dedent

TC39 Proposal to remove common leading indentation from multiline template strings

https://tc39.es/proposal-string-dedent/

MIT License

625 stars 17 forks source link

Stage 3 Checklist #54

Open jridgewell opened 2 years ago

jridgewell commented 2 years ago

[x] Spec Text
[ ] Reviewers
- [x] @rricard
- [ ] @ljharb
- [ ] @mpcsh
- [x] @rpamely
[ ] Editors
- [x] @bakkot
- [ ] @syg
- [ ] @michaelficarra

Action Items

[x] Dedent raw array, and cook into cooked array: https://github.com/tc39/proposal-string-dedent/issues/57
- https://github.com/tc39/proposal-string-dedent/pull/60
[x] Ensure String.cooked and our copied AO remain up to date: https://github.com/tc39/proposal-string-dedent/issues/62
[x] Reference LineTerminator production: https://github.com/tc39/proposal-string-dedent/issues/61
- https://github.com/tc39/proposal-string-dedent/pull/63
[x] Make cache registry per-realm.

rricard commented 2 years ago

Happy to be checked as "reviewed" once #63 is mereged. You will also be able to mark @rpamely as reviewed as he currently is on holiday until the next tc39 meeting and we looked at the proposal together.

ljharb commented 2 years ago

Why is the GlobalDedentRegistry shared by all realms? Template tag arrays are only shared within a single realm, i believe.

jridgewell commented 2 years ago

Because I copied the Symbol.for impl without really thinking about it. I think this can be made per-realm.

jridgewell commented 1 year ago

Ping @ljharb, @mpcsh, @saraghp for reviews.

Ping @bakkot, @syg, @michaelficarra for editor reviews.

sarahghp commented 1 year ago

Thank, @jridgewell. Unfortunately, I am no longer taking part in TC39. Can't wait to see this land from here in userland, though!

mpcsh commented 1 year ago

hi! sorry for the delay — I'm slowly unburying myself from my github notifications. will take a look this coming week.