Open jridgewell opened 2 years ago
Happy to be checked as "reviewed" once #63 is mereged. You will also be able to mark @rpamely as reviewed as he currently is on holiday until the next tc39 meeting and we looked at the proposal together.
Why is the GlobalDedentRegistry shared by all realms? Template tag arrays are only shared within a single realm, i believe.
Because I copied the Symbol.for
impl without really thinking about it. I think this can be made per-realm.
Ping @ljharb, @mpcsh, @saraghp for reviews.
Ping @bakkot, @syg, @michaelficarra for editor reviews.
Thank, @jridgewell. Unfortunately, I am no longer taking part in TC39. Can't wait to see this land from here in userland, though!
hi! sorry for the delay — I'm slowly unburying myself from my github notifications. will take a look this coming week.
Action Items
raw
array, and cook intocooked
array: https://github.com/tc39/proposal-string-dedent/issues/57String.cooked
and our copied AO remain up to date: https://github.com/tc39/proposal-string-dedent/issues/62