search

tc39 / proposal-temporal

Provides standard objects and functions for working with dates and times.
https://tc39.es/proposal-temporal/docs/
Other
3.32k stars 150 forks source link

v8 implementation feedback to ICU team #2196

Closed FrankYFTang closed 1 week ago

FrankYFTang commented 2 years ago

Just to tracks issues I report to ICU team while I attemp to implement the intl support of Temporal.Calendar by using ICU 71-1

Slides https://docs.google.com/presentation/d/1xDQAd_64rjjXOIGeFFWafRWWC8Yn6L2v_RgxVbj-Y0Y/edit#slide=id.g128864141cc_0_41 I also proposal additional changes to ICU 72-1. The shape of the API may be changed by ICU TC next Thursday but I think the doc show the reason why I need to make such proposal. It will be very hard to implement Temporal.Calendar (in particular for ChineseCalendar, DangiCalendar, and HebrewCalendar ) w/o these changes. Also see how ugly (those option A in my slide) if we use the 71-1 API to implement it. https://docs.google.com/document/d/1Zts_kWWniA_SnVBguSwjfpyiZxtZ7m3mVnLYbmXhmhM/edit#

FrankYFTang commented 2 years ago

@sffc @ryzokuken @anba

FrankYFTang commented 2 years ago

The ICU ticket is https://unicode-org.atlassian.net/browse/ICU-22027

ptomato commented 2 years ago

I will look into this in more detail later, but what jumped out at me is that if you are adding Temporal month codes for leap months to ICU, they should be like M05L, not L05.

FrankYFTang commented 2 years ago

I will look into this in more detail later, but what jumped out at me is that if you are adding Temporal month codes for leap months to ICU, they should be like M05L, not L05.

I am so glad you capture this issue. I somehow mentally always though it was L05 but you are right, it should be M05L. I will correct them ASAP.

justingrant commented 1 week ago

I believe that the issues described here have been addressed in the 2+ years since this was opened, so I'm going to close this issue. Feel free to reopen if needed!