search

tc39 / proposal-upsert

ECMAScript Proposal, specs, and reference implementation for Map.prototype.upsert
https://tc39.es/proposal-upsert/
MIT License
202 stars 14 forks source link

Update specification text to match the intent of the proposal #61

Closed johauke closed 3 weeks ago

johauke commented 1 month ago

Fixed indentation errors that changed the behavior of the proposal from the intended functionality. The specification text should also better match other similar functions such as Map.prototype.set and Map.prototype.get now.

johauke commented 3 weeks ago

I changed the WeakMap specificaton to throw a TypeError if CanBeHeldWeakly(key) returns false, since if it fails we can't do comparison to the other keys in the map and we won't be able to insert a new value.
I haven't changed how the callbackFunction is called as I'm uncertain if it should be as mentioned in #63, or if it should be like how Map.prototype.forEach does it.

dminor commented 3 weeks ago

This looks good to me, but we'll also need to request reviewers at the next plenary session.