search

tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.33k stars 460 forks source link

Array methods on top of proxies objects with array targets #1730

Open leobalter opened 6 years ago

leobalter commented 6 years ago

This is feedback after reviewing this contributed test

ynahmany commented 3 years ago

Hi @leobalter, is this one still relevant?

rwaldron commented 3 years ago

@ynahmany Neither @leobalter or I have had a chance to follow up on this. It involves reviewing the test linked above, then searching through Test262 to determine existing coverage and whether or not its sufficient. Once determined, this would either be closed, or new tests would be written.

ynahmany commented 3 years ago

@rwaldron thanks for the quick reply. Sounds like some work needs to be done in order to validate the value for such tests. I am actually want to start contributing, any other low hanging fruit for me here perhaps?

rwaldron commented 3 years ago

Honestly, this is a great place to start! This would allow you to familiarize yourself with different aspects of the work done here.

rwaldron commented 3 years ago

Take a look in test/built-ins/Array/* (there's a lot there!) for tests that include Proxy and familiarize yourself with what is being covered. Then in test/built-ins/Proxy/*, find all the tests that operate on arrays and build the same familiarity. Once you feel like you have a good grasp on what's covered, look in the test that @leobalter linked to and see if there is anything in there that's novel. Take that idea and write a new test for it!

leobalter commented 3 years ago

@ynahmany I second everything already said by @rwaldron here. Thanks for contributing to the project!

Sounds like some work needs to be done in order to validate the value for such tests.

Yes, the given test is a bit stressing out repetition, which is beyond of the scope for covering the specs text. Ideally in the OP I just wanted to make sure we cover Array methods using Proxies as the this value, making sure they act normal, like a regular array. Some variations could be as in the given example of changing properties as Symbol.isConcatSpreadable and revoking a proxy.

A basic set would be enough, as creativity could extend tests to a long exhaustion here. Anyway, bonus points if you find anything inconsistency between implementations, but that's unlikely to happen.

rwaldron commented 3 years ago

@leobalter thanks for the additional details!