search

tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.31k stars 459 forks source link

chore(ci): Update branch version for ES-META repo #4089

Closed Zaid-maker closed 3 months ago

Zaid-maker commented 4 months ago

Updates the branch version to clone in CI to v0.4.1.

Changes

Zaid-maker commented 4 months ago

Anyone review??

ljharb commented 4 months ago

@jhnaldo, can you confirm?

jhnaldo commented 4 months ago

@ljharb Yes, I checked that the latest version of ESMeta is compatible with the newest version of Test262. Since the latest version of ESMeta is v0.4.1, I think it is better to update to this version.

I ran all applicable 25,115 Test262 tests and found the following five failed test cases:

  1. language/expressions/assignment/destructuring/keyed-destructuring-property-reference-target-evaluation-order.js
  2. language/expressions/assignment/target-super-computed-reference.js
  3. language/expressions/assignment/destructuring/iterator-destructuring-property-reference-target-evaluation-order.js
  4. language/expressions/member-expression/computed-reference-null-or-undefined.js
  5. language/expressions/assignment/target-member-computed-reference.js

However, all of them are related to https://github.com/tc39/ecma262/issues/3295 and https://github.com/tc39/ecma262/pull/3307. So, updating the version of ESMeta should be fine.

@Zaid-maker, I'm sorry there has been no update on ESMeta, and thanks for your kind suggestion. From now on, I'll update the version of ESMeta for every release, not only in ecma262 but also in test262.

Zaid-maker commented 4 months ago

As I explained in the comment, I suggest to update the version of ESMeta to v0.4.1.

Ok

Zaid-maker commented 3 months ago

CI looks happy :)