Testing plan for JSON-parse-with-source

[ioannad]

Proposal README Proposal rendered spec

For testing the tests, the proposal is shipped in v8.

---

• [x] Tests for new function JSON.isRawJSON:
  • [x] Boilerplate:
  • [x] Function length.
  • [x] Function name.
  • [x] Property descriptor.
  • [x] Function is not a constructor.
  • [x] Can be invoked as a function with success cases:
  • [x] An instance created by a call to JSON.rawJSON.
  • [x] Some objects without an [[IsRawJSON]] internal slot: {}, [].
  • [x] Some non-Objects: null, undefinded, a Boolean, a symbol, a number.
• [ ] Tests for new function JSON.rawJSON:
  • [x] Boilerplate:
  • [x] Function length.
  • [x] Function name.
  • [x] Function is not a constructor.
  • [x] Property descriptor.
  • [ ] Can be invoked as a function
  • [x] Success cases
    • [x] Number, negative number, string, true, false, null
    • [x] Returned object has the correct shape (null prototype, rawJSON own property)
    • [ ] Returned object is frozen
  • [ ] Failure cases, throwing:
    • [x] SyntaxError in case of:
    • [x] The empty string.
    • [x] A string starting or ending with a tab, a linefeed, a carriage return, or a space.
    • [x] A non-Array object literal: {}.
    • [x] An Array literal: [1].
    • [ ] TypeError when trying to extend a rawJSON result object.
• [ ] Tests for the new abstract operations in the algorithm of JSON.parse, each test should have a callable reviver argument:
  • [x] For paths in CreateJSONParseRecord, only success cases (normal output), a test for each branch:
  • [x] an Array literal
  • [x] an Object literal
  • [x] an Object literal with a repeated key
  • [x] NullLiteral, BooleanLiteral, NumericLiteral, StringLiteral, ArrayLiteral, ObjectLiteral, UnaryExpression
  • [x] a combination of all the above success cases nested
  • [ ] For paths in InternalizeJSONProperty, and the interaction with JSON.stringify, test with a reviver that modifies the holder object, as mentioned in tc39 issue 39:
    • [ ] [array and plain object] overwrite of not-yet-processed entry should result in absence of source for that entry
    • [ ] primitive to non-primitive
    • [ ] non-primitive to primitive
    • [ ] non-primitive to a clone (same date but different identity)
    • [ ] primitive to a different primitive
    • [ ] [array and plain object] overwrite and restoration of not-yet-processed entry should preserve source for that entry
    • [ ] primitive
    • [ ] non-primitive
    • [ ] [array] splicing out an item should result in absence of source from the affected index forward
    • [ ] ...but restoring items at their original index should preserve source
• [ ] Test the overall intended functionality with examples from the proposal README and slides (linked in README).
  • [ ] Test that reviver function is applied to the source, not the parsed value, by roundtripping:
  • [ ] JSON.parse(" 9999999999999999", (key, val) => BigInt(val)) // → 9999999999999999n
  • other?

[ioannad]

I hope I didn't miss important test cases, and that the plan is not too much or too little. Any comments are very welcome!

I make the start by migrating the staging tests by the v8 project authors.

[ptomato]

I removed "Brand check for this method" - JSON.isRawJSON and JSON.rawJSON are static methods, so there's no instance to brand-check.

Here is one more suggestion: On the return value of JSON.rawJSON(), the rawJSON property cannot be modified or deleted and has the correct property descriptor.