tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.31k stars 459 forks source link

Temporal: Remove tests for part of the approved slate of removals #4108

Closed ptomato closed 3 months ago

ptomato commented 3 months ago

Mostly deletions, and some replacements of deleted API.

This makes tests compliant with the following removals that reached consensus in the TC39 meeting of 2024-06-12:

See: tc39/proposal-temporal#2846, tc39/proposal-temporal#2847, tc39/proposal-temporal#2848, tc39/proposal-temporal#2849.

ptomato commented 3 months ago

Thanks for the quick review. Luckily, very few actual changes, mostly just removals.

littledan commented 3 months ago

Can we add some new tests to assert that these methods aren't exposed? I think it's a pretty likely bug that someone will forget to remove some of them.

ptomato commented 2 months ago

The difficult part about that, I realized, is that it's totally spec-compliant to forget to remove them, according to https://tc39.es/ecma262/#sec-conformance. Although we don't want that, due to the risk of not being able to add them back in the future! So I'd still want to go ahead with it regardless.