search

tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.3k stars 457 forks source link

Add tests for RegExp.escape #4123

Closed leobalter closed 1 month ago

leobalter commented 2 months ago

Initial implementation of tests for RegExp.escape. I still need to review if I'm missing coverage here or running the tests.

leobalter commented 2 months ago

Thanks @bakkot! I fixed some coverage. I'll have a hard stop for now but will continue later.

leobalter commented 2 months ago

This should be ready for another round of reviews.

leobalter commented 2 months ago

Thanks, @ljharb! I believe I addressed all the review points so far.

ljharb commented 1 month ago

Are these ready to merge? I'm hoping to ask for stage 3 at this month's plenary.