search

tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.3k stars 457 forks source link

RAB: Integrate staging tests for the .filter method #4125

Closed ioannad closed 1 month ago

ioannad commented 1 month ago

of Array.prototype and TypedArray.prototype

This is part of PR https://github.com/tc39/test262/pull/3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

ioannad commented 1 month ago

Was there a Array/prototype/filter/resizable-buffer-shrink-mid-iteration.js in the original PR? It's a bit odd that there's only the TypedArray version in this PR.

Otherwise looks fine, possibly remove the noStrict flag.

@ptomato Not sure, I'll check tomorrow in more detail and change the PR label when I'm done.

ioannad commented 1 month ago

@ptomato:

Was there a Array/prototype/filter/resizable-buffer-shrink-mid-iteration.js in the original PR? It's a bit odd that there's only the TypedArray version in this PR.

There was not, neither in #3888 not any tests in staging for Array.prototype.filter when shrinking mid-iteration. Do you think this should be tested as well, either here or in a follow-up PR adding missing tests?

Otherwise looks fine, possibly remove the noStrict flag.

Removed.

ptomato commented 1 month ago

Shrinking mid-iteration with filter is fine to add in a followup. I wouldn't consider it that high of a priority, it's just odd that it's tested everywhere else and not here.