tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.3k stars 457 forks source link

RAB: Integrate staging tests for the .forEach method #4134

Closed ioannad closed 1 month ago

ioannad commented 1 month ago

of Array.prototype and TypedArray.prototype

This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js

This one also did not have any ..-shrink-.. tests under Array/prototype, neither in #3888 nor in the staging tests themselves.

ioannad commented 1 month ago

Like one of the previous PRs, this one is missing Array/prototype/forEach/resizable-buffer-shrink-mid-iteration.js - no need to block the PR but let's write it down for later.

@ptomato I think I misunderstood your previous comment about the missing Array/prototype/forEach/resizable-buffer-shrink-mid-iteration.js tests. Although there were no staging tests for this, I could try to add some in the obvious ways, parallel to the TypedArray "shrink" tests.

ptomato commented 1 month ago

What I understood from the shrink test and reading the spec: