search

tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.41k stars 468 forks source link

Add staging source-phase-imports #4244

Closed legendecas closed 1 month ago

legendecas commented 2 months ago

Even though https://github.com/tc39/proposal-esm-phase-imports will supersede this test case, as https://tc39.es/proposal-source-phase-imports/#sec-source-text-module-record-getmodulesource is defined in the spec, add a staging test to cover import a SourceTextModule source.

Refs: https://github.com/tc39/test262/pull/3980#pullrequestreview-1822534491

syg commented 2 months ago

Wait, you don't need to manually add staging tests if you're working in V8. You can add these as part of the V8 CL and there's a 2-way sync bot that'll take care of the exporting. In that case you can run these tests as part of the V8 CQ.

legendecas commented 2 months ago

Yeah, I tried that. But the tools (and v8 test runner) complain about the folders that do not exist in test262 repo. So I manually picked the change here.

ptomato commented 2 months ago

There's no link to the V8 CL but if someone reviewed these there, I'm happy to click the merge button if for whatever reason the bot can't do it.

syg commented 2 months ago

There's no link to the V8 CL but if someone reviewed these there, I'm happy to click the merge button if for whatever reason the bot can't do it.

Please hold off for a little bit. I want to make sure whether there's a bug / unsupported use case with the 2-way sync bot.

legendecas commented 1 month ago

closed in favor of https://github.com/tc39/test262/pull/4252