tc39 / test262

Official ECMAScript Conformance Test Suite
Other
2.4k stars 466 forks source link

CI improvements #4307

Closed ptomato closed 2 weeks ago

ptomato commented 3 weeks ago

Migrate linter and test generation workflow to GitHub Actions, and add some improvements

To merge this, we'll have to go into the settings, set the "ci/circleci: Test262: verify tools; build & lint tests" workflow to non-required, merge it, and then go back to the settings and set whichever new workflows we'd like to require.

ptomato commented 3 weeks ago

Screenshot of what the linter annotations look like: Screenshot from 2024-11-04 17-28-14

ptomato commented 2 weeks ago

Hopefully everyone's happy with the current state of this.

@ljharb would you mind doing the honors with the settings? You'll have to set "ci/circleci: Test262: verify tools; build & lint tests" to non-required, merge the PR, then set "Checks / Lint tests" and "Checks / Build generated tests" to required. I think it's under "Code and automation → Branches" in the settings. (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule)

ljharb commented 2 weeks ago

All done. Merge at wil.

ptomato commented 2 weeks ago

Merged!