search

tcallsen / jquery-star-rating-plugin

Automatically exported from code.google.com/p/jquery-star-rating-plugin
0 stars 0 forks source link

Incorrect jQuery Version Compatibility Statement #135

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Plugin Version:
v4.11 (2013-03-14)

jQuery Version:
1.7

Problem:
I've skipped your suggested issue format because most of the information 
doesn't apply. On your site, as of the version mentioned, you say "NEW 
(18-Feb-2013): Compatible with jQuery 1.3+ and the latest 1.9!"

However, on lines 239 and 257 you make a call to jQuery's addBack() method, 
which was only added in version 1.8 http://api.jquery.com/addBack/

It's an easy fix to maintain current functionality without the addBack() 
method, though you might devise something more graceful:

239                         this.prevAll().filter('.rater-'+ 
control.serial).addClass('star-rating-hover');
240                         this.addClass('star-rating-hover');
...
257                         var starson = current.length ? 
current.prevAll().filter('.rater-'+ control.serial) : null;
258                         if(starson){ starson.addClass('star-rating-on'); 
current.addClass('star-rating-on'); }

Original issue reported on code.google.com by LivingR...@gmail.com on 22 May 2013 at 7:16