Use $input.data by default in place of null

tcallsen / jquery-star-rating-plugin

Automatically exported from code.google.com/p/jquery-star-rating-plugin

0 stars 0 forks source link

Use $input.data by default in place of null #139

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Hello :)

Small suggestion :

($.metadata? input.metadata(): ($.meta?input.data():null)) || {}, /* metadata 
options */

=>

($.metadata? input.metadata(): input.data()) || {}, /* metadata options */

data attributes are widely used now, so, in case the metadata plugin is not 
used, let's use the data attributes, wdyt?

Thx for the great job!

Regards,

Raphaël

Original issue reported on code.google.com by rdeho...@gmail.com on 27 Sep 2013 at 11:22

GoogleCodeExporter commented 9 years ago

I'll make this change and release it asap. But please follow us on github now 
because we won't be maintaining google code much longer.
https://github.com/Fyneworks-jQuery/star-rating

Original comment by diego.a...@gmail.com on 27 Sep 2013 at 11:26

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Great! Thx!

Original comment by rdeho...@gmail.com on 27 Sep 2013 at 11:29