tcalmant / ipopo

iPOPO: a Service-Oriented Component Model for Python
https://ipopo.readthedocs.io/
Apache License 2.0
69 stars 28 forks source link

org.osgi.framework.uuid should be set on framework construction #95

Closed scottslewis closed 6 years ago

scottslewis commented 6 years ago

The framework uuid in ipopo is set to the property named 'framework.uid' in the Framework constructor. RSA requires access to the framework uuid and the spec indicates that the uuid has name: 'org.osgi.framework.uuid'. It would be helpful if the same uuid was set by the framework to both 'framework.uid' and 'org.osgi.framework.uuid'.

tcalmant commented 6 years ago

Agreed. This property is set in pelix/framework.py, line 634. As this is a read-only property, there are no problem storing the framework_uid variable with the new name, alongside the old one.

scottslewis commented 6 years ago

Hi Thomas. Ok, I'll produce a pull request.

scottslewis commented 6 years ago

Here is the pull request

https://github.com/tcalmant/ipopo/pull/96

tcalmant commented 6 years ago

Thanks for the pull request :)