Include License in pypi distribution

tcalmant / python-javaobj

Extended fork of python-javaobj from http://code.google.com/p/python-javaobj/

Apache License 2.0

81 stars 19 forks source link

Include License in pypi distribution #36

Closed CJ-Wright closed 4 years ago

CJ-Wright commented 4 years ago

Would it be possible to include the license in the pypi distribution via a manifest.in file? This would help a lot with downstream packaging like conda-forge. https://github.com/conda-forge/javaobj-py3-feedstock/pull/2

tcalmant commented 4 years ago

Hi, I won't be able to change the project before Thursday, but I can do that for a 0.4.0.1 version. Also, two questions:

does the file require the .txt extension or do I keep it as is ?
do I need to add an entry in setup.cfg/setup.py to link to the license file ?

CJ-Wright commented 4 years ago

Thank you very much!

I don't think it needs to have an extension, and I don't think you need to link to it in the setup.py.

tcalmant commented 4 years ago

Hi Christopher, I've published v0.4.0.1 that includes the LICENSE, the README and the AUTHORS. I've also added an entry in setup.py to force the license file name to LICENSE.

Also, the requirements were missing in setup.py.

I let you close the issue if everything works on your side.

CJ-Wright commented 4 years ago

Thank you very much! The current build checks out! https://github.com/conda-forge/javaobj-py3-feedstock/pull/3