tcbrindle / NanoRange

Range-based goodness for C++17
Boost Software License 1.0
358 stars 28 forks source link

Fix copy'n'paste error in front_insert_iterator #103

Closed siebenschlaefer closed 4 years ago

siebenschlaefer commented 4 years ago

https://github.com/tcbrindle/NanoRange/blob/275a8088ae5a7bb409a2ef9c60e9df5f3fae3c72/include/nanorange/iterator/front_insert_iterator.hpp#L33

This looks like a copy & paste error where back_insert_iterator.hpp was copied and push_back() was mistakenly changed to front_back instead of push_front like in line 27:

https://github.com/tcbrindle/NanoRange/blob/275a8088ae5a7bb409a2ef9c60e9df5f3fae3c72/include/nanorange/iterator/front_insert_iterator.hpp#L27

Disclaimer: I just started toying with NanoRange, so the code may be totally fine. In that case just close this issue, sorry. Also, I didn't find any tests for the insert iterators, so I couldn't add a test case.

tcbrindle commented 4 years ago

That is definitely a copy-and-paste error, well spotted!

tcbrindle commented 4 years ago

Fixed in #104