tcbrindle / flux

A C++20 library for sequence-orientated programming
https://tristanbrindle.com/flux/
Boost Software License 1.0
472 stars 29 forks source link

Fix MSVC warnings #105

Closed tcbrindle closed 1 year ago

tcbrindle commented 1 year ago

A couple of warnings have slipped in when compiling with MSVC, so let's squish 'em.

We'll also disable C4702 "unreachable code" as we get a ton of these when compiling the tests with optimisation and they all seem like false positives.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (87b50c5) 97.67% compared to head (a753e28) 97.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================== - Coverage 97.67% 97.67% -0.01% ========================================== Files 66 66 Lines 2237 2236 -1 ========================================== - Hits 2185 2184 -1 Misses 52 52 ``` | [Files Changed](https://app.codecov.io/gh/tcbrindle/flux/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle) | Coverage Δ | | |---|---|---| | [include/flux/op/set\_adaptors.hpp](https://app.codecov.io/gh/tcbrindle/flux/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle#diff-aW5jbHVkZS9mbHV4L29wL3NldF9hZGFwdG9ycy5ocHA=) | `86.11% <ø> (ø)` | | | [include/flux/core/assert.hpp](https://app.codecov.io/gh/tcbrindle/flux/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle#diff-aW5jbHVkZS9mbHV4L2NvcmUvYXNzZXJ0LmhwcA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.