tcbrindle / flux

A C++20 library for sequence-orientated programming
https://tristanbrindle.com/flux/
Boost Software License 1.0
472 stars 29 forks source link

Fix multidim benchmark CI failure #135

Closed tcbrindle closed 9 months ago

tcbrindle commented 9 months ago

It looks like MSVC's STL now provides C++23 std::views::cartesian_product, which clashes with the polyfill version we use for the multidim benchmark.

Fortunately, there's a feature test macro we can use to detect whether the std version exists, so we'll use that to select the std version if possible or otherwise fall back to our version.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc97bee) 97.70% compared to head (8c26757) 97.70%.

:exclamation: Current head 8c26757 differs from pull request most recent head 5a512b7. Consider uploading reports for the commit 5a512b7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ======================================= Coverage 97.70% 97.70% ======================================= Files 67 67 Lines 2398 2398 ======================================= Hits 2343 2343 Misses 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.