Closed isaacy2012 closed 2 months ago
So first of all, please accept my apologies @isaacy2012 for letting this PR languish for months. I'm afraid I was pretty busy at the time you originally submitted it so I intended to review it later, and then I somehow I never got back to looking at it. I feel very bad!
The good news is that this PR looks great! I've just got a couple of small comments but otherwise this looks awesome.
If you've moved on in the intervening time and don't feel like coming back to this then I quite understand :). I'll be happy to do a final polish if you're busy with other things.
Thanks, and apologies again
Hi @tcbrindle, no worries at all, I'll address those changes this weekend :)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.22%. Comparing base (
d7bbf7c
) to head (6cefba1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @isaacy2012!
Addresses, #172: The element type of flux::cartesian_product, cartesian_power and adjacent is a tuple of the element type(s) of the underlying sequences. These three adaptors also provide *_map versions, which take an n-ary function and call it directly with the underlying elements. This is to avoid forming a tuple and then immediately destructuring it, as would happen in a subsequent call to map(unpack(func)).
This commit adds the *_map version for the zip adaptor.