search

tcbrindle / flux

A C++20 library for sequence-orientated programming
https://tristanbrindle.com/flux/
Boost Software License 1.0
476 stars 29 forks source link

CI: test with GCC13 #59

Closed tcbrindle closed 1 year ago

tcbrindle commented 1 year ago

Now that GCC13 has been released, we should add it to our CI set up.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.49 :warning:

Comparison is base (99531e6) 98.51% compared to head (d07e1eb) 97.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== - Coverage 98.51% 97.03% -1.49% ========================================== Files 63 58 -5 Lines 2288 1921 -367 ========================================== - Hits 2254 1864 -390 - Misses 34 57 +23 ``` [see 30 files with indirect coverage changes](https://codecov.io/gh/tcbrindle/flux/pull/59/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tcbrindle commented 1 year ago

Reported code coverage seems to have gone down in many places (including a rather alarming 100% drop take_while_adaptor!). If I had to guess I'd say this is because GCC13 is now inlining more stuff at -O0, which is actually a good thing but means we'll have to put up with CodeCov complaining for a while