Closed jwest591 closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -0.19
:warning:
Comparison is base (
404b732
) 97.85% compared to head (08f98af
) 97.66%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @jwest591, thanks for the PR, and in particular for all the test additions, it looks great.
@jnytra, set_union
was yours originally, are you happy to merge?
@jwest591 Please could you pull the latest upstream Flux change so we can re-test the MacOS CI? (Github Actions made some changes but things should be working again now with the latest fix)
Don't worry about the CodeCov "failure", it's a strange fact of life that with a template library and mostly constexpr tests, sometimes adding a new runtime test case can cause reported coverage to go down because more code becomes "live" in the final binary...
@jnytra I'm going to merge this as I think the fix is good, let me know if you see any problems
Merged, thanks very much @jwest591
You're welcome! Glad it was useful.
Thanks for the fix @jwest591, it also looks good for me @tcbrindle. :-)
last() must return a cursor with cursor_type::second otherwise comparing against a cursor obtained via successive inc() calls fails.
This change also allows flux::to work with set_union.