tcbrindle / flux

A C++20 library for sequence-orientated programming
https://tristanbrindle.com/flux/
Boost Software License 1.0
476 stars 29 forks source link

Fix element type of cartesian_product_with #89

Closed tcbrindle closed 1 year ago

tcbrindle commented 1 year ago

We were missing a -> decltype(auto) off a lambda and so always returning by value. Oops.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (404b732) 97.85% compared to head (64bcab0) 97.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #89 +/- ## ======================================= Coverage 97.85% 97.85% ======================================= Files 65 65 Lines 2191 2195 +4 ======================================= + Hits 2144 2148 +4 Misses 47 47 ``` | [Impacted Files](https://app.codecov.io/gh/tcbrindle/flux/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle) | Coverage Δ | | |---|---|---| | [include/flux/op/cartesian\_product\_with.hpp](https://app.codecov.io/gh/tcbrindle/flux/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle#diff-aW5jbHVkZS9mbHV4L29wL2NhcnRlc2lhbl9wcm9kdWN0X3dpdGguaHBw) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/tcbrindle/flux/pull/89/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tristan+Brindle)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.