0.0.151 Diff background remove issues

tcd / dark-plus-syntax

VS Code's default dark theme, but just a little bit better.

https://marketplace.visualstudio.com/items?itemName=dunstontc.dark-plus-syntax

Other

56 stars 14 forks source link

0.0.151 Diff background remove issues #7

Closed urielzen closed 5 years ago

urielzen commented 5 years ago

0.0.151 removed the background color to Diff window. I believe that without the background color it is harder to identify where the new changes are happening.

Compare with original

Also the scrolling bar does not show where the changes are happening anymore. now:

before:

urielzen commented 5 years ago

bump

chrisgbaker commented 5 years ago

Definitely still an issue. It's caused me to pick a different theme until this is fixed, as it makes the diff tool very cumbersome, especially the lack of the sidebar.

chrisgbaker commented 5 years ago

In reading the docs, i believe this is an easy fix: I believe this theme is specifying both, which may be messing this up now. Not sure if this is a new change to how VSCode applies themes.

urielzen commented 5 years ago

@chrisgbaker fortunately there is an option in vscode to install a previous version so you dont have to switch themes.

chrisgbaker commented 5 years ago

@urielzen thanks! I wasn’t sure if that would work or if it was due to a change in vscode, but I’ll try that tomorrow

tcd commented 5 years ago

Hey @urielzen and all,

Sorry I didn't see this earlier. I'll look into this asap, thank you for bringing it to my attention. Will post progress back to this issue.

Thanks, Clay

tcd commented 5 years ago

@urielzen @chrisgbaker y'all take a look at the highlighting in 0.0.154 and let me know if there are still any issues.

urielzen commented 5 years ago

Thanks, it works great with the latest version!