Closed BradyBonnette closed 1 year ago
After this is merged in, Ill be able to take down the old setup. It might be a little flaky until then.
LGTM?
Yeah the majority of the work here is on the ops side. If you're curious about it, Ill happily explain it in Discord. You can see all the trials I did with the number of commits I made to test / retry / test / retry cycle that's common with CI.
This may not seem like a large change, but it paves the way for better aarch64 runner support.
Most of the work here was on the ops side (git repo not included) combined with Github Webhooks, but the idea is that any time we need any task to run on a self-hosted aarch64 runner, we supply a launch template ID in the format of
launch_template_id__<actual launch template id>
. The old self-hosted runner setup had some edge cases where restarting failed jobs wouldn't work properly, and wouldn't work at all if you were using astrategy.matrix
. This new method works in all cases and simplifies things in the workflow .yaml files.