tcgoetz / GarminDB

Download and parse data from Garmin Connect or a Garmin watch, FitBit CSV, and MS Health CSV files into and analyze data in Sqlite serverless databases with Jupyter notebooks.
GNU General Public License v2.0
1.1k stars 138 forks source link

no name value in field 'activities.name' if subsport is cardio #181

Closed lorenzovercruysse closed 1 year ago

lorenzovercruysse commented 1 year ago

Hi, first of all thanks for putting an effort in this great and open-source tool! I'm new so I'm not aware of any conventioning. But I'm glad to give my support in the abilities I have. Therefore I'll be looking out for some issues I come across and report them here.

Describe the bug In the table 'activities', records with sub_sport 'cardio_training' have a NULL value in the field 'name', while there is a name on the activity.

To Reproduce Steps to reproduce the behavior:

  1. Create an activity on garmin connect with activity type 'cardio', make sure it has a name.
  2. import latest data through script
  3. open sqlite db 'garmin_activities' and query 'select * from activities where sub_sport = 'cardio_training'
  4. See the value in field 'name'

Expected behavior The name of the activity represented in the table.field 'activities.name'

alexis-m commented 1 year ago

Huh, I checked my db, and the following sport/sub_sport activities have NULL in the name column: training/cardio_training, kayaking/generic, stand_up_paddleboarding/generic.

I can see that Garmin Connect web sites shows the names, and that the downloaded json files for the corresponding activities have the activityName field. I haven't checked the downloaded fit files yet.

AlexAve8 commented 1 year ago

Have you found a solution to this? I am encountering a similar issue with Virtual Rides.

These activities have NULL in the name, sport, sub_sport and some more columns.

tcgoetz commented 1 year ago

commit 8c521a52aa54247ccfa8dc75a93ea7fa65355aa0

tcgoetz commented 1 year ago

fixed in: https://github.com/tcgoetz/GarminDB/releases/tag/v3.4.0