Enable download of GPX without conversion

tcgoetz / GarminDB

Download and parse data from Garmin Connect or a Garmin watch, FitBit CSV, and MS Health CSV files into and analyze data in Sqlite serverless databases with Jupyter notebooks.

GNU General Public License v2.0

1.1k stars 138 forks source link

Enable download of GPX without conversion #200

Closed J4cker14 closed 10 months ago

J4cker14 commented 11 months ago

CLI extended with --gpx option for enabling of GPX download instead of zipped fit file
--gpx-path enable definition where to download GPX files instead of loading paths from config file

tcgoetz commented 11 months ago

What are you trying to achieve here? Are you only interested in downloading GPX files for activities? Do you also intend to analyze your data? GaminDb's core usecase is download and analyze data. I can see downloading GPX files in addition to FIT and JSON files, based on a setting. I think an option that ONLY downloads GPX files would need a big warning printed to the screen or users will set it and then file a bug that their is no data in their database.

It's also worth mentioning that GarminDbs style is to put things like --gpx-path in the config file rather than on the command line.

J4cker14 commented 11 months ago

Yes, goal is to download only gpx, no db.

Warning should be there, Im in. Config question.. Yes and no. Yes, I can add it there also, but to keep it simply and enable smooth automation, which is also portable - to have full control (config override if any) via CLI

Now CI has to create config, use it .. OR my proposel, to enable CLI override like limit of number activities, target path and so on ...

Config is fine, but simetimes, I need to quickly change number of last activities. As I have script in "PATH" I can simply run script from anywhere, but to access config - that requires some extra effort.

tcgoetz commented 11 months ago

I think https://github.com/kjkjava/garmin-connect-export is a better fir for what you're trying to do. It already downloads GPX files. Downloading data is just a bit of what GarminDb is for. I think adding command line options to just download GPX files would add confusion and support issues for people who are trying to use GarminDb for it's intended purpose.