search

tcgoetz / GarminDB

Download and parse data from Garmin Connect or a Garmin watch, FitBit CSV, and MS Health CSV files into and analyze data in Sqlite serverless databases with Jupyter notebooks.
GNU General Public License v2.0
1.1k stars 138 forks source link

Unclear what python version is required #218

Closed thebigredorb closed 6 months ago

thebigredorb commented 8 months ago

Describe the bug Documentation error: It is unclear what Python version is required. setup.py indicates >= 3.0. READNE.md sais 3.x. Success stories seems to indicate that 3.8+ works. But my experience is that 3.9 is required, due to the usage of venv option "-upgrade-deps", which was introduced in 3.9

To Reproduce Run make setup with python < 3.9

Expected behavior README.md and setup.py could indicate a more precise python version requirement.

Logs

Please run bugreport.sh and attach bugreport.zip.

Additional context

This is of course only a small inconvenience, but it can take som time to figure out. Thanks for your great work :)

tcgoetz commented 6 months ago

Python version required for development (running make commands, etc) is more strict than what is required for using a pip installed package. Pip installed package requires 3.x. Development is 3.9+.

tcgoetz commented 6 months ago

make setup now checks the version of python vs whats required for development.