search

tcgoetz / GarminDB

Download and parse data from Garmin Connect or a Garmin watch, FitBit CSV, and MS Health CSV files into and analyze data in Sqlite serverless databases with Jupyter notebooks.
GNU General Public License v2.0
1.18k stars 142 forks source link

Make fails in version checking on Ubuntu #226

Open yee-jonathan opened 7 months ago

yee-jonathan commented 7 months ago

Describe the bug When making from Source on a freshly installed Ubuntu instance, running into an error where python cannot see functions imported from garmindb.version. Commenting out the version check allows the install to proceed. This is after installing build-essentials, which allows form make

To Reproduce Steps to reproduce the behavior:

  1. Clone from GitHub using SSH
  2. Ensure make is on host
  3. Run make setup

Expected behavior A clear and concise description of what you expected to happen.

Logs Screenshot 2024-04-08 153230

Additional context I initially thought the import was erroring due to the virtual environment not activating. When running source .venv/bin/activate then make setup, I would get an error related to import fitfile

Screenshot 2024-04-08 153825

projectHolsey commented 7 months ago

For whomever maintains this - Line 32 .GarminDB/garmindb/version.py Left an additional parameter ('verbose') in the function call.

Line 72 in Makefile - the line 'python' doesn't work when the alias for the python exe is 'python3' - default for ubuntu.